Bug #355

poor error feedback of scm access checker

Added by Robert Haschke almost 5 years ago. Updated almost 5 years ago.

Status:ClosedStart date:2014-12-17
Priority:NormalDue date:
Assignee:Florian Lier% Done:

100%

Category:-Spent time:0.50 hour
Target version:-

Description

colossus(rhaschke):citk>python ~/src/citk.tools/citk-access-check/bin/citkac.py . lsp-famula-nightly.distribution

yields:
Error: Could not load JSON from String. Distribution file or Project file Syntax is faulty. Exiting. Invalid control character at: line 11 column 70 (char 384)

No hint, which of the dozens of files is affected.

History

#1 Updated by Jan Moringen almost 5 years ago

  • Assignee set to Florian Lier

#2 Updated by Florian Lier almost 5 years ago

Will fix this asap

#4 Updated by Florian Lier almost 5 years ago

Any feedback?

I deleted a ":" in the flobi-core stuff on purpose. Now the output is as follows:


[flier@thorium]-[/homes/flier/dev/citk/citkac/citk.tools/citk-access-check]
[17:12]$ python bin/citkac.py /homes/flier/dev/CITK/dist/ lsp-famula-nightly.distribution

!! THIS CLIENT IS INTENDED TO TEST NON-INTERACTIVE SCM CHECKOUTS !!
!! IT USES CREDENTIALS STORED IN ~/.netrc OR ~/.subversion FILES !!

>> Processing Distribution file /homes/flier/dev/CITK/dist/lsp-famula-nightly.distribution
>> For now, ONLY GIT and SUBVERSION checking is supported. Sorry.

------------------------------------------------------------

 Error: Could not load JSON from String. Distribution file or Project file Syntax is faulty. Exiting. Expecting : delimiter: line 2 column 17 (char 18)
 File: {
    "name"      "flobidev-core-sim",
    "templates": [ "cor-lab", "cmake-catkin" ],

    "variables": {
        "description":      "flobi morse simulation",

        "repository":       "https://projects.cit-ec.uni-bielefeld.de/git/flobidev.core/",
        "sub-directory":    "sim/",
        "branches":         [ "master", "0.1" ],

        "redmine.instance": "https://projects.cit-ec.uni-bielefeld.de",
        "redmine-project":  "flobidev",

        "extra-requires":   [
            [ "cmake-catkin", "flobidev-core-server" ],
            [ "cmake", "morse" ]
        ],

        "extra-provides":   [
            [ "cmake-catkin", "flobidev-core-sim" ]
        ]
    }
}

#5 Updated by Florian Lier almost 5 years ago

  • Status changed from New to Feedback

#6 Updated by Robert Haschke almost 5 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100

Some code refactoring to allow printing of errornous file name.
Added escaping of tabs in JSON string literals (additional to newlines), which eventually caused the error.

#7 Updated by Florian Lier almost 5 years ago

Thx for the modification!

Also available in: Atom PDF